Dimitri Papadopoulos Orfanos

Results 345 comments of Dimitri Papadopoulos Orfanos

> So the important distinction for me with the `auth_request_vpn_allocation()` call was whether it happens once or whether it happens each time. I'm afraid don't know. I've always used `run_tunnel()`...

> Reference code... I try to where I can. Specifically for HDLC you might want to use the code from RFC 1662 - unless you have found performance issues?

@Perlovka You're right, however the daemon itself shouldn't need to run as root either, at least for creating the tunnel. Only routing and DNS server changes at the system level...

This is the code of interest: https://github.com/adrienverge/openfortivpn/blob/075b2ae/src/io.c#L209-L215 You could try to **`break`** (instead of **`continue`**). Perhaps `read` returning 0 after `select` returning 1 is **not** expected in a normal situation....

Just read the comment from @mrbaseman. The issue you report occurs when reading from PPP : ``` n = read(tunnel->pppd_pty, &buf[off_w], PKT_BUF_SZ - off_w); ``` The difference here is probably...

@mrbaseman Mmmh... I'm pointing out there are two issues here: 1. How and where is the TCP keepalive implemented on Linux and not in FreeBSD? Perhaps the different PPP implementations?...

I suspect `break` is the proper solution for Linux too - but I fear it might break _openfortivpn_ because of other bugs/issues - so it's hard to apply such a...

> This could be related to how the [io_loop](https://github.com/adrienverge/openfortivpn/blob/075b2aec5f8047c35a17e2c4a6fe42817683134e/src/io.c#L614) is implemented, the pthread stuff and semaphores... changing `continue` to `break` as suggested [above](https://github.com/adrienverge/openfortivpn/issues/794#issuecomment-713479783) is perhaps not a wise move. It...

> The observation, however, was that this didn't help at least on MacOSX. So I didn't have a clear idea how I should proceed further in #613 . When a...

According to #795 `SO_KEEPALIVE` does not seem to be set by default on Linux: ``` SO_KEEPALIVE: 0 TCP_KEEPIDLE: 7200 TCP_KEEPINTVL: 75 TCP_KEEPCNT: 9 ``` or FreeBSD: ``` SO_KEEPALIVE: 0 TCP_KEEPIDLE:...