slickgrid-es6 icon indicating copy to clipboard operation
slickgrid-es6 copied to clipboard

queuePostProcessedRowForCleanup: Missing rowIdx on call, or missing default-value for rowIdx

Open ststeiger opened this issue 7 years ago • 1 comments

There is function queuePostProcessedRowForCleanup(cacheEntry, postProcessedRow, rowIdx) (in file slick.grid.js)

It gets called in

    // ////////////////////////////////////////////////////////////////////////////////////////////
    // Interactivity

    function handleMouseWheel(e)
    [...]
    queuePostProcessedRowForCleanup(zombieRowCacheFromLastMouseWheelEvent,
                        zombieRowPostProcessedFromLastMouseWheelEvent);

It's missing the rowIdx parameter, and it's not setting a default-value anywhere...

ststeiger avatar Apr 05 '18 04:04 ststeiger

Possible - this is from slick original code. Feel free to send pr

On Thu, 5 Apr 2018 at 7:58 am, Stefan Steiger [email protected] wrote:

Accessing non-existant variable columnIdx in function queuePostProcessedRowForCleanup (slick.grid.js)

Should that be rowIdx, or is it missing a parameter ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DimitarChristoff/slickgrid-es6/issues/33, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHSzKZBfjs9Alag41uV35bVkeangtB3ks5tlaRugaJpZM4TH260 .

-- Dimitar Christoff

"JavaScript is to JAVA what hamster is to ham" @D_mitar - https://github.com/DimitarChristoff

DimitarChristoff avatar Apr 06 '18 17:04 DimitarChristoff