IceCubesApp
IceCubesApp copied to clipboard
Improve swipe actions
- Remove icons from menus
- Fix two gray buttons together being difficult to distinguish
- Add a new toggle to use theme tint colors instead of button colors (of boost, favorite, bookmark ones)
- With the toggle turned off (use default button colors):
-
- on (use theme colors):
-
What I'm not sure about
- Where should be the toggle at? display settings or swipe actions settings?
- Default value
I'll wait for @sothawo opinion but here is mine:
- I like colors related to the actions, so I would be ok with the default settings being button colors sound good to me.
- The toggle should be alongside the swipe actions settings.
2 places we are talking about:
-
the icons in the picker in the settings pane (not in the popup, there the alignment is alright), but where the icons are shown in front of the label: They should be removed from the settings pane but be kept in the popup. When I implemented it - before that change came in that added these icons - I deliberately left the icons out because I thought that looks not good.
-
the actual swipes:
- I'd rather keep the icons instead of text only, but this could be a preference setting as well (icons/text/icons+text)
- the colors being configurable (like it is now as default) or using tint as the outer and grey as the inner. It's hard to decide if there are two grey buttons side by side, as they can be randomly configured to be on either side so you do not know if the yellow favorite is next to the tinted boost and the gray reply and quote on the other side, or the yellow favorite is togeher with a gray reply and the tinted boost with another gray. So for me the two options would be
- tint/gray on both sides like I had it in the first version
- icon colors like now
Oh yes. We definitely need icons in the swipe actions.
I can have a look when I'm back from work later this evening
Looks fine for me, love it that I can keep my preferred coloring 😄
LGTM?
There I take 15 minutes for breakfast and when coming back to the laptop, the PR is merged. But the only thing I wanted to say is that perhaps the option "text only" could have been added. But I wouldn't use that anyway.