IceCubesApp icon indicating copy to clipboard operation
IceCubesApp copied to clipboard

make share and copy links translatable

Open maco opened this issue 2 years ago • 1 comments

I was filing a ticket about the following when I realized I could just fix it, so here's an explanation of the bug, along with a PR for the fix. I'm unsure if I need to add the untranslated English one to every other language file, or if it'll automatically fall back to English. (I would guess it varies by programming language & framework.) So, if I need to add the English as placeholders in other files, please just let me know.

The ShareLink() in AccountDetailView.swift (and elsewhere) is called without passing an argument for the label, so the text is left untranslated. For example, here's a screenshot from my phone, which is in Spanish: IMG_BF2AEBBAB7B2-1

Similarly, the ShareLink in StatusCardView.swift does have a label, but it's a hard-coded string, not translatable. Same for the copy option. IMG_29F5617133DC-1

maco avatar Jan 31 '23 03:01 maco

Thanks!

Dimillian avatar Feb 01 '23 17:02 Dimillian