IceCubesApp icon indicating copy to clipboard operation
IceCubesApp copied to clipboard

Bug: GIF-based avatars don't display

Open yankcrime opened this issue 2 years ago • 4 comments

My avatar was uploaded to my Mastodon instance as a GIF, and whilst this displays fine in the site and other clients in Ice Cubes it's just blank. If I change to a PNG or a JPG it displays just fine.

yankcrime avatar Jan 23 '23 09:01 yankcrime

another example: @[email protected], doesn't render in icecubes

sothawo avatar Feb 09 '23 14:02 sothawo

That's a problem with the Image Engine Nuke, which is used for the profile images (https://github.com/kean/Nuke). That bug is now fixed, but that fix isn't yet implemented in Ice Cubes, as there is no new version of nuke. Additionally, the version of Nuke used in Ice Cubes isn't the current one, so that has to be updated too. @Dimillian You could obviously directly reference the commit (https://github.com/kean/Nuke/commit/df63473487c6b716247f0c42630ba4b6aa7b68b1) or main-branch of nuke, but I guess you'd probably rather wait until @kean bumps the version number.

Havhingstor avatar Feb 09 '23 14:02 Havhingstor

See https://github.com/kean/Nuke/issues/668

Havhingstor avatar Feb 09 '23 14:02 Havhingstor

Awesome!

Dimillian avatar Feb 09 '23 15:02 Dimillian

I push version 11.6.2. Thanks, @Havhingstor, for finding the root causing and fixing it. It's also worth fixing it on the Gifu level for folks who are using it directly. I'll try to take care of it when I can unless someone else does it earlier.

kean avatar Feb 09 '23 22:02 kean