IceCubesApp
IceCubesApp copied to clipboard
Dimillian
Dark theme background colors are flipped
When Nemesis Light Mode is selected, the background color of posts and pressable menu items in the settings screen are rendered #ffffff, with their surroundings rendered off-white. This is expected behavior. However, in Nemesis Dark Mode, the primary and secondary background colors don't follow expected behavior for Apple's theming guidelines. Specifically, the pressable menu items in the settings page should be #1c1c1e, and the color of the background view should be #000000, with the color of posts matching the background view's color this time around.
A good example for how this should look is the Settings app:
| Settings (Light) | Settings (Dark) |
|---|---|
 |
 |
Compare this with Ice Cubes's theming method:
| Ice Cubes (Light) | Ice Cubes (Dark) |
|---|---|
 |
 |
Continuing on this, I would also love to see a "default iOS look" theme; given that the app is written using SwiftUI and greatly matches Apple's own design aesthetic, I think following Apple's Foundations colors would make a lot of sense. I assume this could easily be added as two new theme options. More specifically, for the light theme, background color is #ffffff, secondary background color is f2f2f7, links are #007aff, and for the dark theme, background color is #000000, secondary background color is #1c1c1e, and links are #0A84ff. That said, it might be cool to see two dark modes, one regular and another AMOLED, as well.
Here is how the app looks with the proposed "default iOS look" themes:
| Light Mode (Regular) | Dark Mode (Regular) | Dark Mode (AMOLED) |
|---|---|---|
 |
 |
 |
And the settings page (of course, as noted in the original post above, dark mode colors need to be flipped):
| Light Mode (Regular) | Dark Mode (Regular) | Dark Mode (AMOLED) |
|---|---|---|
 |
 |
 |
For the regular dark mode, I am using #1c1c1a for the background color and #2c2c2e for the secondary background color.
Also, while creating this issue, I have stumbled upon another bug: while a light theme (i.e. a theme with dark text) is selected, if you change the background color to a dark one, the text stays dark, rendering everything unreadable. To fix it, you have to first pick a dark theme (i.e. a theme with light text) and then modify the colors.
I had Nemesis Light Mode selected and changed the background colors, resulting in the following:
Quickly: the flip is actually a conscious design decision. I was wondering if anyone would comment on it haha.
