IceCubesApp icon indicating copy to clipboard operation
IceCubesApp copied to clipboard

Feature request: pop-up player is much smaller than the timeline preview on iPads

Open sh95014 opened this issue 2 years ago • 5 comments

  1. On an iPad, scroll to a post with a video.
  2. Tap on it to play.

Expected: inline playback, or full-screen playback

Actual: a portrait-orientation pop-over containing a much smaller video than in the preview, which is ridiculous. See screenshot and note that the preview area is actually ample:

IMG_35E538A94D1E-1副本

There is a button in the sheet's navbar to invoke a full-screen player from there, but it's misleadingly labeled as ⓘ which generally means "info".

I think what happened is that an iPhone-ism wasn't disabled on iPads. Tapping on the video in the timeline view should either play inline or invoke the full-screen player, not this intermediate sheet that serves no purpose on iPads.

sh95014 avatar Nov 08 '23 20:11 sh95014

The i-Button invokes the OS-quickview (That's also what it does in iOS). The button-label should therefore probably be the label commonly used for quickview in the OS, which I don't know out of the top of my head right now.

Havhingstor avatar Nov 09 '23 11:11 Havhingstor

I think QuickLook is rarely invoked with an explicit button, but the SF Symbols app returns "eye" and "eye.fill" if you search for "quicklook".

sh95014 avatar Nov 09 '23 19:11 sh95014

That is the button in the macOS Finder Toolbar, too (If you have QuickLook in the toolbar). This sounds like a fitting label nonetheless, it might be worth changing.

Havhingstor avatar Nov 09 '23 21:11 Havhingstor

Or, if there's only one attachment in the toot, skip the MediaUIView() and bring up the .quickLookPreview directly for that attachment. That would avoid the pointless pop-up?

sh95014 avatar Nov 16 '23 14:11 sh95014

The pointless popup was requested many, many times by ton of users because QuickLook si slow and don't have good dismiss gesture. What I could do is make it full screen on iPad tho, so it could be bigger.

Dimillian avatar Nov 16 '23 15:11 Dimillian