ACHNBrowserUI icon indicating copy to clipboard operation
ACHNBrowserUI copied to clipboard

Text in Acknowledgements Rows

Open Jerrot opened this issue 4 years ago • 5 comments

In the German translation of the current release (1.3), I can see a different text behaviour in the About -> Acknowledgements (“Danksagungen”) section. While the first row ends with an ellipsis glyph (UIKit speech: .byTruncatingTail), the others - e.g. third and last row - just happily line-break.

E106283E-277D-4497-A682-B153BA66A0EC

Jerrot avatar May 17 '20 07:05 Jerrot

Danke für den Hinweis! Da hab ich wohl auch eine Übersetzung übersehen. Ich schaue es mir mal an.

TheVaan avatar May 17 '20 09:05 TheVaan

Hey @Dimillian, you may take a look here: there is no truncating in makeRow but for some reason, contributor entry is truncated

TheVaan avatar May 17 '20 09:05 TheVaan

Not fixed though. Anyway, I think it might be a SwiftUI bug actually and mostly I was curious. :)

Jerrot avatar May 23 '20 09:05 Jerrot

I thought I fixed it... yeah so I think I have to set a width or numberOfLines I'll take another look.

Dimillian avatar May 23 '20 10:05 Dimillian

Maybe the problem is, that the text fits inside the line but the > overlaps, so the word get truncated. The rows where it breaks line correctly doesn’t fit in a single line so line break is necessary.

TheVaan avatar May 23 '20 10:05 TheVaan