ACHNBrowserUI icon indicating copy to clipboard operation
ACHNBrowserUI copied to clipboard

Swipe to Add to Collection

Open sw0rdfish opened this issue 4 years ago • 5 comments

Hey all. New here. Gonna try to jump in with helping on things but I’ve never coded in swift. See if I can catchup fast.

Would be better if swiping right added a bug/fish/item to your collection. I also find a check might be better than a star for the non swipe method? It took me a bit to figure out star wasn’t favouriting meaning something else. Thoughts?

sw0rdfish avatar May 11 '20 17:05 sw0rdfish

Screenshot 2020-05-11 at 19 41 58 Screenshot 2020-05-11 at 19 42 11 Screenshot 2020-05-11 at 19 42 17 So it's a heart for villager, a checkmark for critters and a star for items. But we could *also* support swipe. It's a bit less discoverable that why I think the one tap to add from the row is also good.

Dimillian avatar May 11 '20 17:05 Dimillian

Weird. Mine has stars for the critters. Is that a bug ? Maybe I’m behind a version

sw0rdfish avatar May 11 '20 17:05 sw0rdfish

It's a bit less discoverable that why I think the one tap to add from the row is also good.

Yeah maybe I just have a tendency to try to swipe? I don’t think you should lose the tap option. I just think the swipe could be an easy way too? Just a suggestion 👍

sw0rdfish avatar May 11 '20 17:05 sw0rdfish

Yes definitely a good idea :)

Dimillian avatar May 11 '20 17:05 Dimillian

This is a great idea. However, from having spent many, many hours implementing a swipeable list using SwiftUI - in order to get a user experience I thought matched what a user would expect, the only way I could get it to work was wrapping a TableViewController, with Apple's supported Swipe Actions, in a UIHostingViewController to replace SwiftUI's List. I had tried 'rolling my own' by using a ZStack and adding gestures - the user experience was ok but never quite perfect and so I ultimately dropped it. There's also some workaround for managing multiple gestures required - which can be seen here on StackOverflow. Both items are very high on my list for improvements to see in SwiftUI 2.0 😊

barclayd avatar May 12 '20 21:05 barclayd