VanillaFix icon indicating copy to clipboard operation
VanillaFix copied to clipboard

VanillaFix crashes Tinkers Construct renderer when sprite is null

Open KnightMiner opened this issue 6 years ago • 1 comments

As seen pretty clearly in our code, the sprite arguments for putTexturedQuad and putrotatedQuad are nullable, however your mixin does not perform a null check. This can lead to crashes when a world has a broken fluid with a missing texture, as seen here.


I would also like to point out its pretty bad practice to ASM another mod's code, especially if that ASM code is going to skip all safety checks (including performing an unchecked cast). This is partly a Mixin problem as there is nothing in the stacktrace that says the crashing code is from VanillaFix (took me at least a month after first seeing this to find VanillaFix is the cause). However, in general if you want compatibility you should talk to the other mod author instead of ASM hacks so we don't have to spend so long finding the cause of crashes like this.


Crash is from VanillaFix 1.0.10.99 for Minecraft 1.12.2

KnightMiner avatar Oct 27 '19 21:10 KnightMiner

https://github.com/SlimeKnights/TinkersConstruct/issues/3967

The workaround for now is to set - B:textureFixes=false

ProsperCraft avatar Mar 08 '20 21:03 ProsperCraft