Rift icon indicating copy to clipboard operation
Rift copied to clipboard

Access transformation for inner classes

Open 0f-0b opened this issue 6 years ago • 1 comments

Minecraft version: 1.13 Rift version: 1.0.4-52

The bug

When trying to change the visibility of any inner class, the access transformer only transforms the class, but does not change any visibility information in the outer class. So accessing the inner class is still a compile-time error.

How to reproduce

  1. In access_transformations.at, add this line: public class wu$a.
  2. Run gradle setupDevWorkspace --rerun-tasks.
  3. Try to access net.minecraft.tags.BlockTags.Wrapper (create a new instance, for example).

0f-0b avatar Aug 22 '18 10:08 0f-0b

can confirm, same for this line that's already in rift: https://github.com/DimensionalDevelopment/Rift/blob/4234dcd9a4ad120fd00f48b0a7528df7cb562476/src/main/resources/access_transformations.at#L30

UpcraftLP avatar Aug 22 '18 14:08 UpcraftLP