Maskbook icon indicating copy to clipboard operation
Maskbook copied to clipboard

Integration Opera Crypto Wallet (continue from PR #6384)

Open anton-red opened this issue 2 years ago • 3 comments

Description

Closes # (NO_ISSUE)

Type of change

  • [ ] Documentation
  • [ ] Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • [ ] My code follows the style guidelines of this project.
  • [ ] I have performed a self-review of my own code.
    • [ ] I have removed all in development console.logs
    • [ ] I have removed all commented code.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • [ ] I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • [ ] I have delegated all web requests to the background service via the internal RPC bridge.

anton-red avatar Sep 06 '22 14:09 anton-red

can you give this pr a meaningful name about what is it doing?

Jack-Works avatar Sep 06 '22 14:09 Jack-Works

@anton-red

Problem 5 and 6 mentioned in https://github.com/DimensionDev/Maskbook/pull/6384#issuecomment-1185260717, still existed, please check.

AinuX avatar Sep 07 '22 09:09 AinuX

@anton-red

Problem 5 and 6 mentioned in #6384 (comment), still existed, please check.

Hi, what about problem 6 Unable to unlock a token. Pleas look to screen record belowe.

https://user-images.githubusercontent.com/112620793/189070907-176c453e-34d3-4e4a-b53f-d2899ec5ee8a.mp4

About problem 5 at this momen Opera Crypto Wallet work on this way. When user make page refreshing, wallet lost the connection.

anton-red avatar Sep 08 '22 08:09 anton-red