Maskbook icon indicating copy to clipboard operation
Maskbook copied to clipboard

Connect to Opera Wallet button added

Open filipkozakred opened this issue 2 years ago • 3 comments

Description

Closes # (NO_ISSUE)

Type of change

  • [ ] Documentation
  • [ ] Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • [x] My code follows the style guidelines of this project.
  • [ ] I have performed a self-review of my own code.
    • [ ] I have removed all in development console.logs
    • [ ] I have removed all commented code.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • [ ] I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • [ ] I have delegated all web requests to the background service via the internal RPC bridge.

filipkozakred avatar May 30 '22 13:05 filipkozakred

Awesome work! Did you try to send any transaction with this new wallet?

Yes, it successfully connects with built in Opera Crypto Wallet

filipkozakred avatar Jul 06 '22 10:07 filipkozakred

@filipkozakred

  1. Opera crypto wallet also support Polygon, please add it as an option when select Polygon chain image

  2. Fail to connect BNB chain with opera wallet.

https://user-images.githubusercontent.com/2582974/179174539-a9690e6d-d064-48a5-80dd-06839b721107.mp4

  1. Fail to switch chain even switch to supported chain.
  2. Since Opear wallet only support ETH, BNB Chain and Polygon, it's better to disable switch to chain unsupported chain and give a reminder message to enduser.

https://user-images.githubusercontent.com/2582974/179174058-793c73c9-6b21-4a0b-9a45-eae528cc6c17.mp4

like this, image

  1. Lost connection after sign message/tx

https://user-images.githubusercontent.com/2582974/179175955-05ce29ef-2e1e-4cb4-a21f-3c4833f28f53.mp4

  1. Unable to unlock a token

https://user-images.githubusercontent.com/2582974/179178695-e95169d6-a6cb-448a-b3d3-4ed56abb3a46.mp4

AinuX avatar Jul 15 '22 07:07 AinuX

Hi @filipkozakred FYI, we have integrated some UI components for testing here.

image image

guanbinrui avatar Jul 19 '22 03:07 guanbinrui