Maskbook icon indicating copy to clipboard operation
Maskbook copied to clipboard

[Task] I18NField in plugin infra

Open Jack-Works opened this issue 3 years ago • 2 comments

  • Remove the "fallback" requirement (make it optional)

Possible problem:

If no fallback provided, it might display the i18n key on the screen, which is the worst result 🤔

  • Change the "Don't remove me" hint, currently, we use __name to indicate a string should not be removed by the analyzer. @UncleBill suggests using Name, but I think it might be too subtle to notice the difference.

I think we need a small discussion on this topic before we change the definition.

Jack-Works avatar May 26 '22 07:05 Jack-Works

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 30 '22 15:07 stale[bot]

Ping

Jack-Works avatar Jul 31 '22 09:07 Jack-Works

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 30 '22 18:09 stale[bot]