Maskbook icon indicating copy to clipboard operation
Maskbook copied to clipboard

feat(Collectible): integrate Magic Eden

Open brymut opened this issue 2 years ago • 11 comments

Description

Integrate Magic Eden into Collectible plugin for NFT information

Closes #5489

Type of change

  • [x] New feature (non-breaking change which adds functionality)

Previews

Checklist

  • [x] My code follows the style guidelines of this project.
  • [x] I have performed a self-review of my own code.
    • [x] I have removed all in development console.logs
    • [x] I have removed all commented code.
  • [x] I have commented on my code, particularly in hard-to-understand areas.
  • [x] I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • [ ] I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • [ ] I have delegated all web requests to the background service via the internal RPC bridge.

brymut avatar Mar 20 '22 17:03 brymut

Still WIP

brymut avatar Mar 20 '22 18:03 brymut

I'm drafting this PR. Feel free to click the Ready for Review button anytime this PR is ready.

guanbinrui avatar Mar 29 '22 03:03 guanbinrui

Could you please have a look @guanbinrui @septs @Jack-Works

brymut avatar Jul 04 '22 16:07 brymut

Could you please have another look @guanbinrui @UncleBill ?

brymut avatar Jul 17 '22 10:07 brymut

Hi @guanbinrui @UncleBill , could you please have a look?

brymut avatar Jul 21 '22 16:07 brymut

Could you please let me know what's needed next? @guanbinrui @UncleBill

brymut avatar Jul 24 '22 14:07 brymut

@brymut

  1. No purchase releated function
  2. No wallet status detection related function
  3. No offer, listing, history information

https://twitter.com/AinuxA/status/1551533028891324416 https://magiceden.io/item-details/AEVfB5hW7GsiPPMLYKEhWLLHQ8LFFf8UbSKzyjQyNEqw?name=TombStoned-High-Society-%233766

image
  1. Detail information is incorrect, please compare with magiceden and opensea, like contract address, token id and mint address

https://twitter.com/AinuxA/status/1551546359333158913 https://magiceden.io/item-details/83AJ5o8JSxFK4uJfjuidtxhgPJdaRaQgDj9pkQYcarwg https://opensea.io/assets/solana/83AJ5o8JSxFK4uJfjuidtxhgPJdaRaQgDj9pkQYcarwg

  1. Actually, we can't load Solana NFT in collectible plugin besides magiceden. image

  2. It's better to shorten the address

image

AinuX avatar Jul 25 '22 12:07 AinuX

Thanks @AinuX , I'll adress each of these issues. For number 1, only Opensea has a purchase function, Rarible & NFTscan don't have purchase functions either.

For number 6, Magic Eden is the only Solana NFT collectible provider, the rest only work on EVM chains and this PR isn't to deal with Opensea's recently added compatibility for Solana, its to integrate MagicEden, can this be tracked separately?

For the rest of the points you have brought up, I'll investigate further.

brymut avatar Jul 25 '22 14:07 brymut

Hi again @AinuX: Resolved number 7: Screen Shot 2022-07-26 at 3 05 29 PM Working on more and will update you.

brymut avatar Jul 26 '22 14:07 brymut

Hi again @AinuX,

I have pushed changes resolve Number 3:

https://user-images.githubusercontent.com/14836056/181619954-9c081363-1c41-47ab-be40-00c08652a020.mov

As for the rest, I believe they are either features exclusive to Opensea or are issues to do with Opensea and not with MagicEden. Could you please have another look? @AinuX @guanbinrui @UncleBill

brymut avatar Jul 28 '22 19:07 brymut

@brymut

https://twitter.com/AinuxA/status/1557908673787482112

the info in details page is still incorrect

telegram-cloud-photo-size-1-5163666239283899200-y

https://magiceden.io/item-details/FtqfGg2ARkeAJsPt7mDuS5GdvkRE7XBZQeBvFkKMZNEM

https://opensea.io/assets/solana/FtqfGg2ARkeAJsPt7mDuS5GdvkRE7XBZQeBvFkKMZNEM

telegram-cloud-photo-size-1-5163666239283899201-y

you can refer to opensea's details data to set magiceden plugin's data

and, for the "created by" field, it's better to query the contract or solana explorer to get the data

like this, the first user who minted the nft

telegram-cloud-photo-size-1-5163666239283899202-y

https://solscan.io/token/FtqfGg2ARkeAJsPt7mDuS5GdvkRE7XBZQeBvFkKMZNEM

AinuX avatar Aug 12 '22 08:08 AinuX

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 12 '22 03:10 stale[bot]