Maskbook
Maskbook copied to clipboard
feat(Collectible): integrate Magic Eden
Description
Integrate Magic Eden into Collectible plugin for NFT information
Closes #5489
Type of change
- [x] New feature (non-breaking change which adds functionality)
Previews
Checklist
- [x] My code follows the style guidelines of this project.
- [x] I have performed a self-review of my own code.
- [x] I have removed all in development
console.log
s - [x] I have removed all commented code.
- [x] I have removed all in development
- [x] I have commented on my code, particularly in hard-to-understand areas.
- [x] I have read Internationalization Guide and moved text fields to the i18n JSON file.
If this PR depends on external APIs:
- [ ] I have configured those APIs with CORS headers to let extension requests get passed.
- chrome extension:
chrome-extension://[id]
- firefox extension:
moz-extension://[id]
- chrome extension:
- [ ] I have delegated all web requests to the background service via the internal RPC bridge.
Still WIP
I'm drafting this PR. Feel free to click the Ready for Review
button anytime this PR is ready.
Could you please have a look @guanbinrui @septs @Jack-Works
Could you please have another look @guanbinrui @UncleBill ?
Hi @guanbinrui @UncleBill , could you please have a look?
Could you please let me know what's needed next? @guanbinrui @UncleBill
@brymut
- No purchase releated function
- No wallet status detection related function
- No offer, listing, history information
https://twitter.com/AinuxA/status/1551533028891324416 https://magiceden.io/item-details/AEVfB5hW7GsiPPMLYKEhWLLHQ8LFFf8UbSKzyjQyNEqw?name=TombStoned-High-Society-%233766

- Detail information is incorrect, please compare with magiceden and opensea, like contract address, token id and mint address
https://twitter.com/AinuxA/status/1551546359333158913 https://magiceden.io/item-details/83AJ5o8JSxFK4uJfjuidtxhgPJdaRaQgDj9pkQYcarwg https://opensea.io/assets/solana/83AJ5o8JSxFK4uJfjuidtxhgPJdaRaQgDj9pkQYcarwg
-
Actually, we can't load Solana NFT in collectible plugin besides magiceden.
-
It's better to shorten the address

Thanks @AinuX , I'll adress each of these issues. For number 1, only Opensea has a purchase function, Rarible & NFTscan don't have purchase functions either.
For number 6, Magic Eden is the only Solana NFT collectible provider, the rest only work on EVM chains and this PR isn't to deal with Opensea's recently added compatibility for Solana, its to integrate MagicEden, can this be tracked separately?
For the rest of the points you have brought up, I'll investigate further.
Hi again @AinuX:
Resolved number 7:
Working on more and will update you.
Hi again @AinuX,
I have pushed changes resolve Number 3:
https://user-images.githubusercontent.com/14836056/181619954-9c081363-1c41-47ab-be40-00c08652a020.mov
As for the rest, I believe they are either features exclusive to Opensea or are issues to do with Opensea and not with MagicEden. Could you please have another look? @AinuX @guanbinrui @UncleBill
@brymut
https://twitter.com/AinuxA/status/1557908673787482112
the info in details page is still incorrect
https://magiceden.io/item-details/FtqfGg2ARkeAJsPt7mDuS5GdvkRE7XBZQeBvFkKMZNEM
https://opensea.io/assets/solana/FtqfGg2ARkeAJsPt7mDuS5GdvkRE7XBZQeBvFkKMZNEM
you can refer to opensea's details data to set magiceden plugin's data
and, for the "created by" field, it's better to query the contract or solana explorer to get the data
like this, the first user who minted the nft
https://solscan.io/token/FtqfGg2ARkeAJsPt7mDuS5GdvkRE7XBZQeBvFkKMZNEM
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.