Maskbook icon indicating copy to clipboard operation
Maskbook copied to clipboard

feat(network): add moonbeam network

Open developerfred opened this issue 2 years ago • 12 comments

Description

Closes #5827 #5826 #5837

Integrate Ecosystem and Network Moonbem

Exchanges

  • BeamSwap. ✅
  • Stella Swap ✅
  • PadSwap ✅

Maskbook core contracts

  • [ ] redPacket https://github.com/DimensionDev/MysteryBox/issues/13
  • [ ] Multicall
  • [ ] BalanceChecker
  • [ ] MysteryBox https://github.com/DimensionDev/MysteryBox/issues/13
  • [ ] ITO - https://github.com/DimensionDev/InitialTwitterOffering/issues/40

Assets

  • [x] Moonbeam tokenlist https://github.com/DimensionDev/Mask-Token-Lists/issues/18
  • [ ] Moonbeam Assets List

Type of change

  • [ ] Documentation
  • [ ] Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

developerfred avatar Mar 09 '22 11:03 developerfred

Hi @developerfred, Plz resolve those conflicts.

guanbinrui avatar Mar 24 '22 14:03 guanbinrui

Hi @developerfred We have deployed contracts on MoonRiver.

Balance Checker: https://moonriver.moonscan.io/address/0xC119574D5Fb333F5AC018658D4d8b5035E16bf39 UniswapInterfaceMulticall: https://moonriver.moonscan.io/address/0x6cc1b1058F9153358278C35E0b2D382f1585854B ITO: https://moonriver.moonscan.io/address/0x981be454a930479d92C91a0092D204b64845A5D6 at block number: 1314566 Dummy Qualification Contract:https://moonriver.moonscan.io/address/0x83D6b366f21e413f214EB077D5378478e71a5eD2 HappyRedPacket: https://moonriver.moonscan.io/address/0x578a7Fee5f0D8CEc7d00578Bf37374C5b95C4b98 HappyRedPacket_ERC721: https://moonriver.moonscan.io/address/0xF9F7C1496c21bC0180f4B64daBE0754ebFc8A8c0

guanbinrui avatar Apr 06 '22 03:04 guanbinrui

Hi @developerfred Plz fix those CI errors.

guanbinrui avatar Apr 07 '22 03:04 guanbinrui

@wenluomask can you check this issue for me?

developerfred avatar Apr 22 '22 18:04 developerfred

@guanbinrui @Jack-Works bug gas-api.metaswap https://gas-api.metaswap.codefi.network/networks/1284/suggestedGasFees Screenshot 2022-04-22 at 20 41 29

developerfred avatar Apr 22 '22 18:04 developerfred

Currently Moonbeam network is not supported yet. Token list is empty as well. Could you go through this pr again? 截屏2022-05-02 下午5 26 34 截屏2022-05-02 下午5 26 49

wenluomask avatar May 02 '22 09:05 wenluomask

Currently Moonbeam network is not supported yet. Token list is empty as well. Could you go through this pr again

Yes sure

developerfred avatar May 02 '22 10:05 developerfred

1.If I use Mask wallet, transactions didn't provide Max priority fee and Max fee; 截屏2022-05-03 下午9 17 09 截屏2022-05-03 下午9 18 33

  1. Dashboard cannot get assets in Moonbeam Network; 截屏2022-05-03 下午9 18 59

  2. US dollar value of token wasn't added; 截屏2022-05-03 下午9 19 06

  3. Since no any DEX supports swap in Moonbeam, why do we open swap in Mask?

wenluomask avatar May 03 '22 13:05 wenluomask

Screenshot 2022-05-05 at 22 12 28

developerfred avatar May 05 '22 21:05 developerfred

there're too many merge conflicts 👀

Jack-Works avatar May 11 '22 16:05 Jack-Works

Hi @developerfred ,

I have checked the latest version of pr just now. I found out that #1-4 were not fixed yet.

For #1, since you are using gas price instead of priority fee and max fee for gas setting, it is incorrect for Moonbeam. Moonbeam supports EIP-1559, so please change back to EIP-1559 transaction gas setting.

For #4, if Moonbeam did support in BeamSwap, Stella Swap and PadSwap as you checked, the token list should not be empty. Could you check again? Screen Shot 2022-05-23 at 11 52 05 AM

wenluomask avatar May 23 '22 03:05 wenluomask

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 08 '22 19:09 stale[bot]