Maskbook
Maskbook copied to clipboard
feat(Trader): integration 1inch protocol
closes #4015
Docs https://docs.1inch.io/api/quote-swap
Using createLookupTableResolver
https://github.com/DimensionDev/Maskbook/pull/4141
plz resolve build error
for this build error to exit I need pr #4141 to be accepted createLookupTableResolver #4141
@developerfred Please fix those build errors.
We need confirmation from @DimensionDev/qa.
Thanks for your effort. There are some issues I found in latest version of pull/4234,
-
I tried the swap pairs Matic->Titan and Matic->Mask in Polygon, but they all failed with errors.; https://polygonscan.com/tx/0x8a47cd176dbfbd144b8bb2527a8c661e483ce080791972640bea227a06ae8c7a https://polygonscan.com/tx/0x259272581d897d17f2398dde62a70037da0dbd2afa52ad6e0df1a1c5e3dd145d
-
I tried swap pair ETH->Mask in Eth mainnet, it failed with error;
-
Compare to 1inch.io, the estimate received and minimum received are different from plugin. Minimum received should be lower than estimate;
-
For the swap pairs that swap from ERC-20 token, such as Titan -> Matic, swap button is showing "Enter an amount", you might forgot to consider ERC-20 token unlock;
@wenluomask Thanks for the review, I'll fix these bugs and retest with the same pairs
@developerfred Any updates?
@developerfred Any updates?
I'm still working, I believe I can send a PR correcting it today.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Hi @developerfred Any updates?
done @septs
Revert done @guanbinrui
Hi @developerfred ,
Please make a new build in CI and merge 2.8.0(the latest production version) into this pr.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.