Maskbook icon indicating copy to clipboard operation
Maskbook copied to clipboard

feat(Trader): integration 1inch protocol

Open developerfred opened this issue 3 years ago • 12 comments

closes #4015

Docs https://docs.1inch.io/api/quote-swap

Using createLookupTableResolver https://github.com/DimensionDev/Maskbook/pull/4141

developerfred avatar Sep 05 '21 21:09 developerfred

plz resolve build error

for this build error to exit I need pr #4141 to be accepted createLookupTableResolver #4141

developerfred avatar Sep 09 '21 17:09 developerfred

@developerfred Please fix those build errors.

guanbinrui avatar Sep 22 '21 05:09 guanbinrui

We need confirmation from @DimensionDev/qa.

guanbinrui avatar Oct 06 '21 08:10 guanbinrui

Thanks for your effort. There are some issues I found in latest version of pull/4234,

  1. I tried the swap pairs Matic->Titan and Matic->Mask in Polygon, but they all failed with errors.; https://polygonscan.com/tx/0x8a47cd176dbfbd144b8bb2527a8c661e483ce080791972640bea227a06ae8c7a https://polygonscan.com/tx/0x259272581d897d17f2398dde62a70037da0dbd2afa52ad6e0df1a1c5e3dd145d Screen Shot 2021-10-08 at 11 50 24 AM

  2. I tried swap pair ETH->Mask in Eth mainnet, it failed with error; Screen Shot 2021-10-08 at 1 36 37 PM

  3. Compare to 1inch.io, the estimate received and minimum received are different from plugin. Minimum received should be lower than estimate; Screen Shot 2021-10-08 at 11 40 54 AM

  4. For the swap pairs that swap from ERC-20 token, such as Titan -> Matic, swap button is showing "Enter an amount", you might forgot to consider ERC-20 token unlock; Screen Shot 2021-10-08 at 12 53 53 PM

wenluomask avatar Oct 08 '21 05:10 wenluomask

@wenluomask Thanks for the review, I'll fix these bugs and retest with the same pairs

developerfred avatar Oct 09 '21 01:10 developerfred

@developerfred Any updates?

guanbinrui avatar Oct 14 '21 03:10 guanbinrui

@developerfred Any updates?

I'm still working, I believe I can send a PR correcting it today.

developerfred avatar Oct 14 '21 04:10 developerfred

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 19 '21 15:12 stale[bot]

Hi @developerfred Any updates?

guanbinrui avatar Mar 23 '22 08:03 guanbinrui

done @septs

developerfred avatar Mar 23 '22 16:03 developerfred

Revert done @guanbinrui

developerfred avatar Mar 29 '22 18:03 developerfred

Hi @developerfred ,

Please make a new build in CI and merge 2.8.0(the latest production version) into this pr.

wenluomask avatar May 23 '22 12:05 wenluomask

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 08 '22 19:09 stale[bot]