DiligentCore icon indicating copy to clipboard operation
DiligentCore copied to clipboard

DLL_DBG_SUFFIX vs CMAKE_DEBUG_POSTFIX

Open drywolf opened this issue 4 years ago • 0 comments

I am adding DiligentCore directly via CMake add_subdirectory() to my project to link against the required libraries while also being able to change the core code for rapid prototyping if necessary.

In my CMakeLists.txt however I use CMake's CMAKE_DEBUG_POSTFIX variable to apply the commonly used <libname>d suffix for CMake targets. But this conflicts with how DiligentCore applies suffixes to its targets ... see DiligentCore/blob/master/Graphics/CMakeLists.txt#L3-L4

This results in the DiligentCore libraries to have the suffixes applied twice:

GraphicsEngineD3D11_64dd.dll
GraphicsEngineD3D12_64dd.dll
GraphicsEngineOpenGL_64dd.dll
GraphicsEngineVk_64dd.dll

From my experience with CMake it's usually the best way to stick with CMake's integrated mechanisms of doing things instead of rolling your own. Would it be a proper fix to change DiligentEngine to just use these CMake integrated variables instead of the currently applied custom solution ?

drywolf avatar Feb 27 '20 12:02 drywolf