mpv-acestream icon indicating copy to clipboard operation
mpv-acestream copied to clipboard

Allow to configure acestream-enginge host var

Open fidodido48 opened this issue 11 months ago • 1 comments

Hi, Ive noticed you hardcoded the acestream-engine host to localhost in your script, but you should make it conifgurable (ie. to allow connect to remote one in lan).

(added)    line  2: local aceStreamHost = "http://127.0.0.1:"
(modified) line 55: aceStreamHost .. aceStreamPort .. "/ace/getstream?content_id=" .. aceContentID

fidodido48 avatar Jan 08 '25 01:01 fidodido48

Hi, Ive noticed you hardcoded the acestream-engine host to localhost in your script, but you should make it conifgurable (ie. to allow connect to remote one in lan).

Hello. I'm not using acestream from a long time but, as far as I remember, the host is always local, at least in the regular use.

You can change it in the script if needed (I see you already did it for yourself). Pull requests are welcome.

Maybe the best way to handle this issue is to expose the port and the localhost as script options to make them configurable outside of the main script file. In the past I only moved the port variable at the top of the script, but this is not the best way to make a property as configurable in mpv scripts.

But I don't know how to expose the above mentioned properties and, honestly, I'm not even interested, so PR are welcome also for this matter, if you are interested.

Digitalone1 avatar Jan 08 '25 08:01 Digitalone1