PyUpdater icon indicating copy to clipboard operation
PyUpdater copied to clipboard

False positive `file_requires_admin` on Windows

Open dimitriepirghie opened this issue 4 years ago • 2 comments

On Windows OS, module pyupdater.client.updates. file_requires_admin(file_path) function gives false positive, because open(file_path, "a+") on any process image file while it's being running always raises PermissionError exception.

Propose to use this check instead: os.access(file_path, os.W_OK)

dimitriepirghie avatar Apr 27 '21 12:04 dimitriepirghie

@dimitriepirghie SGTM

JMSwag avatar Apr 28 '21 01:04 JMSwag

Hi I'm also seeing this issue, would it be possible to release the fix?

pm990320 avatar Jul 20 '21 13:07 pm990320