SoapCore
SoapCore copied to clipboard
fix: [DI] Resolve IMessageInspector2 Using Scope Resolver
----IMessageInsector2 is being Added as Scope Service, However, it is being resolve as Sington Service
Could you please update your branch from the latest "develop"? Needed to fix some things to make CI work
Hi @andersjonsson
The CI/CD test for the pull request is encountering a fetch error. Would you mind re-running the test to resolve this issue?
Here is the specific fetch command that is causing the issue:
fetch https://dl-cdn.alpinelinux.org/alpine/v3.19/main/x86_64/APKINDEX.tar.gz
Please update your branch with the latest "develop". I've fixed the issues there
Thanks, I have pulled the latest changes from the 'develop' branch.
Hope this works!
I think you pulled the changes from your own develop-branch, including the code for custom serializers.
When I look at the code for resolving IMessageInspector2 I'm not sure that the changes make sense.
Since the serviceProvider is passed in to each invoke it should be resolved as registered. I suppose you have an indication that this isn't the case. What is the issue you are running into?
Hi @andersjonsson ,
Referring to commit [Git Hub Commit#58afbb9]](https://github.com/DigDes/SoapCore/pull/982/commits/58afbb9b5d7582da6e4c189859c77f7822a5d23e), The IMessageInspector2
has been resolved as a scoped dependency.
As you mentioned, serviceProvider is passed into each invoke it should be resolved as registered. However, It is noted that the IMessageInspector2
has been registered as scoped
but resolved as singleton
.
Have changed from singleton di resolve to scope di resolve in src/SoapCore/SoapEndpointMiddleware.cs
.
Hi @andersjonsson
I hope you're doing well.
I wanted to check in and see if you've had a chance to look into the issue I sent over earlier. If you need any additional information, please let me know.
Regards; Ankit