SoapCore
SoapCore copied to clipboard
Added Optional Custom Serializer in Soap Core
Added Custom Soap Core Serializer using DI If Custom Soap Core Serializer NOT found, Then Fall back for default Soap Core Serializer
Please fix the build errors in the test project and I will take a look. I would also like you to add a test case to make sure that it works and won't break by future changes
And thank you for the PR 😄
Hi,
Fixed build error(s) for Middleware in test proj and added new test case for Serializer.
Let me know if there is anything to add.
There are plenty of failing tests. Please take a look and fix that
Fixed! and Updated Docs for Latest Code.
@andersjonsson any comments?
I think it looks fine. I would like you to change the name though. SoapCoreSerializer
is a bit too close to SoapSerializer
. Since it serializes input parameters I think that should be reflected in the name in some way.
Hi @andersjonsson
Changed from ISoapCoreSerializer
to IXmlSerializationHandler
, which emphasizes serialization without explicitly mentioning "input parameter" while still conveying the purpose of the interface.
I think I'm ready to merge this. There are conflicts in SoapCoreOptions.cs that has to be resolved first though
@andersjonsson any news on this?
The conflicts are still there. Please resolve them, then I can merge this branch
@andersjonsson Resolved the conflicts and updated the code. Could you look and let me know if you need anything else?
Thank you!