SoapCore icon indicating copy to clipboard operation
SoapCore copied to clipboard

Added Optional Custom Serializer in Soap Core

Open ankitkmrpatel opened this issue 1 year ago • 9 comments

Added Custom Soap Core Serializer using DI If Custom Soap Core Serializer NOT found, Then Fall back for default Soap Core Serializer

ankitkmrpatel avatar Oct 19 '23 07:10 ankitkmrpatel

Please fix the build errors in the test project and I will take a look. I would also like you to add a test case to make sure that it works and won't break by future changes

andersjonsson avatar Oct 19 '23 07:10 andersjonsson

And thank you for the PR 😄

andersjonsson avatar Oct 19 '23 07:10 andersjonsson

Hi,

Fixed build error(s) for Middleware in test proj and added new test case for Serializer.

Let me know if there is anything to add.

ankitkmrpatel avatar Oct 19 '23 10:10 ankitkmrpatel

There are plenty of failing tests. Please take a look and fix that

andersjonsson avatar Oct 19 '23 11:10 andersjonsson

Fixed! and Updated Docs for Latest Code.

ankitkmrpatel avatar Oct 26 '23 14:10 ankitkmrpatel

@andersjonsson any comments?

ankitkmrpatel avatar Jan 11 '24 06:01 ankitkmrpatel

I think it looks fine. I would like you to change the name though. SoapCoreSerializer is a bit too close to SoapSerializer. Since it serializes input parameters I think that should be reflected in the name in some way.

andersjonsson avatar Jan 19 '24 13:01 andersjonsson

Hi @andersjonsson

Changed from ISoapCoreSerializer to IXmlSerializationHandler, which emphasizes serialization without explicitly mentioning "input parameter" while still conveying the purpose of the interface.

ankitkmrpatel avatar Feb 14 '24 05:02 ankitkmrpatel

I think I'm ready to merge this. There are conflicts in SoapCoreOptions.cs that has to be resolved first though

andersjonsson avatar Feb 20 '24 08:02 andersjonsson

@andersjonsson any news on this?

ankitkmrpatel avatar Jun 12 '24 10:06 ankitkmrpatel

The conflicts are still there. Please resolve them, then I can merge this branch

andersjonsson avatar Jun 13 '24 07:06 andersjonsson

@andersjonsson Resolved the conflicts and updated the code. Could you look and let me know if you need anything else?

ankitkmrpatel avatar Jun 24 '24 11:06 ankitkmrpatel

Thank you!

andersjonsson avatar Jun 25 '24 06:06 andersjonsson