rules_typescript_proto icon indicating copy to clipboard operation
rules_typescript_proto copied to clipboard

Published 20 hours ago • verified publisher icon Dig-Doug

Strip out _virtual_imports packages to support well known types

Open kellycampbell opened this issue 5 years ago • 3 comments

This is a first pass at working with the well known types and _virtual_imports. If this looks like a good approach, I can add some tests for it.

Fixes #4

kellycampbell avatar Nov 18 '19 12:11 kellycampbell

I added a wkt to one of the protos and the commonjs test passes, but I'm getting a failure in the web test for which I couldn't figure out the right solution.

30 11 2019 12:59:54.601:WARN [web-server]: 404: /google-protobuf/google/protobuf/timestamp_pb.js

kellycampbell avatar Nov 30 '19 13:11 kellycampbell

I haven't tested extensively, but this seems to work for me after merging. https://github.com/gonzojive/rules_typescript_proto/commit/41da6ce1735605ba3ef32b1498550cd3e3181667

gonzojive avatar Mar 22 '20 18:03 gonzojive

What's the status of this? I just realised that I can't easily dep on "@com_google_protobuf//:empty_proto".

farcaller avatar Jan 26 '21 17:01 farcaller