jaxDecomp icon indicating copy to clipboard operation
jaxDecomp copied to clipboard

Fix slice unpad

Open ASKabalan opened this issue 9 months ago • 3 comments

Fixed slice_unpad, now it supports complex numbers

ASKabalan avatar May 04 '24 14:05 ASKabalan

Ignore the formatting error. It is fixed in another PR Once you merge https://github.com/DifferentiableUniverseInitiative/jaxDecomp/pull/17 and https://github.com/DifferentiableUniverseInitiative/jaxDecomp/pull/12 and I wll rebase and this should be ok

This PR is good to go after the other two

ASKabalan avatar May 04 '24 14:05 ASKabalan

@ASKabalan can you try to rerun your precommit locally to squash the formatting test error?

EiffL avatar May 07 '24 18:05 EiffL

Yes all is green locally. But at some point this formatting error correction slipped here and I think it fixes this issue. Any ways this PR should come after the other two

ASKabalan avatar May 07 '24 18:05 ASKabalan

rebased and fixed commit history

ASKabalan avatar Jun 13 '24 11:06 ASKabalan