Homey-SolarPanels icon indicating copy to clipboard operation
Homey-SolarPanels copied to clipboard

Add support for APsystem micro-converters using ECU-R

Open rkokkelk opened this issue 3 years ago • 2 comments

Continued PR from #175 . Due to rebase on different branch new PR had to be created. Main difference is that this PR is based on the sdk-v3 branch instead of master.

With the discussion based on the separation of responsibility in the apsystems module. I'm not looking forward to duplicating basically the same code and having to maintain it in two separate locations. I understand your maintainability point of view, how about I give you direct access to the repo so that you can modify it as you see fit. So that the code is not duplicated but you can still modify for maintainability of this app.

rkokkelk avatar Nov 26 '21 13:11 rkokkelk

Are you sure this compiles? The TypeScript compiler seems to find quite a few issues (see 'files changed', TypeScript errors are embedded in there).

DiedB avatar Nov 27 '21 15:11 DiedB

There were indeed some issues which should now be resolved. Some issues mentioned by tsc which are shown in 'files changed' were due to typescript not detecting inheritance. I've fixed those by running:

npm i --save-dev @types/node

rkokkelk avatar Nov 27 '21 22:11 rkokkelk