dice icon indicating copy to clipboard operation
dice copied to clipboard

added docs and corrected info code

Open sa-k-shore opened this issue 1 year ago • 10 comments

Feature Added : https://github.com/DiceDB/dice/issues/146 Add support for COMMAND DOCS command https://github.com/DiceDB/dice/issues/641 Add support for COMMAND DOCS command Description

Add implementation of "command docs" (internal/eval/eval.go) Add unit test for "command docs" Add integration test for "command docs" Add benchmark test for "command docs"

fixed inconsistency in "command info" (internal/eval/eval.go) wrt redis slight modification of unit test for "command docs" slight modification of integration test for "command docs"

Problems Persisting : we need to add many fields into CmdMeta like complexity etc, thanks

sa-k-shore avatar Oct 07 '24 11:10 sa-k-shore

@arpitbbhayani @JyotinderSingh @lucifercr07

sa-k-shore avatar Oct 08 '24 05:10 sa-k-shore

@sa-k-shore please resolve conflicts

lucifercr07 avatar Oct 12 '24 07:10 lucifercr07

@sa-k-shore please resolve conflicts

Done @lucifercr07

sa-k-shore avatar Oct 13 '24 09:10 sa-k-shore

Hi @sa-k-shore, thank you for the changes. Please check any for any issues causing check failure. Additionally we have recent merges for Command subcommands docs. Please rebase your branch to get the latest changes. Thanks

apoorvyadav1111 avatar Oct 13 '24 14:10 apoorvyadav1111

Hi @sa-k-shore, Hope you are well. I am excited to know about your progress on this issue. As you know, we would like to close this issue soon, please reach out to me or anyone on the discord community if you need any help.

Thanks.

apoorvyadav1111 avatar Oct 18 '24 05:10 apoorvyadav1111

Screenshot 2024-10-21 at 12 20 25 AM hi @apoorvyadav1111 can i know why are this debug logs coming as errors are they errors ?

sa-k-shore avatar Oct 20 '24 18:10 sa-k-shore

@apoorvyadav1111 sorry for delay , can you rerun the workflows if they fail i will fix them

sa-k-shore avatar Oct 20 '24 18:10 sa-k-shore

can you re run it @apoorvyadav1111 i just saw some other testcases are there that were failing i fixed those

sa-k-shore avatar Oct 21 '24 06:10 sa-k-shore

hi @apoorvyadav1111 can you rerun workflow, thanks

sa-k-shore avatar Oct 22 '24 05:10 sa-k-shore

@sa-k-shore please resolve conflicts and check this comment once. https://github.com/DiceDB/dice/pull/993#discussion_r1810586699

lucifercr07 avatar Oct 23 '24 06:10 lucifercr07

hi @lucifercr07 its been long since this pr is not merged can we merge it and i will write those its as another pr and will get it merged.

sa-k-shore avatar Oct 24 '24 14:10 sa-k-shore

hi @lucifercr07 its been long since this pr is not merged can we merge it and i will write those its as another pr and will get it merged.

Okay please go ahead and create an issue for the same, will assign, then we can proceed with merge.

lucifercr07 avatar Oct 24 '24 15:10 lucifercr07

@lucifercr07 created one issue can you assign that to me #1192

sa-k-shore avatar Oct 24 '24 15:10 sa-k-shore