dice icon indicating copy to clipboard operation
dice copied to clipboard

#972: fix: Fixes output of RPUSH command

Open Aditya-Chowdhary opened this issue 1 year ago • 5 comments

Fixes #972 by returning length instead of OK in RPUSH.

Aditya-Chowdhary avatar Oct 05 '24 22:10 Aditya-Chowdhary

Hi @arpitbbhayani @Aditya-Chowdhary, I'm facing issue in connection of the dice cli to the live server, the live server listens to port 7379 ("version":"0.0.4","port":7379).. and the dice cli connects to and on running dice it gives this, Error 111 connecting to 127.0.0.1:6379. Connection refused.

For now i've done a hack starting docker using -p 6379:7379, which enables me to play around, but as soon as i want to write and test that code, i've to build an image which is very redundant process always. Please help, thank you.

kaustubhdeokar avatar Oct 06 '24 14:10 kaustubhdeokar

@kaustubhdeokar. The Redis server runs on port 6379, and the DiceDB Server runs on 7379. However, by default, the dice-cli connects to port 6379. You aren't able to run the cli on default mode because nothing is running on port 6379. To connect to dice-db using the cli, run dice -p 7379. You can run dice --help to see the default behaviour. Your docker hack works because you are running the running the server on 6379 using -p 6379:6379

Aditya-Chowdhary avatar Oct 06 '24 15:10 Aditya-Chowdhary

Thanks a lot @Aditya-Chowdhary

kaustubhdeokar avatar Oct 06 '24 15:10 kaustubhdeokar

Hi @Aditya-Chowdhary , I think there was some issue with the merge/rebase; We have commits from the master branch in the PR. Thanks Apoorv

apoorvyadav1111 avatar Oct 10 '24 09:10 apoorvyadav1111

I am not sure what is happening in this PR. The changes don't seem to be matching what is mentioned in the description.

JyotinderSingh avatar Oct 13 '24 10:10 JyotinderSingh

Hi @apoorvyadav1111 @JyotinderSingh apologies for the confusion. I had originally made this PR to fix the output of the RPUSH command, but a duplicate PR has been merged in. As there seems to have been a problem with the rebase/merge as noted above, and as I will be unable to contribute for a couple of days, I will close this PR, and make a new one to work on the changes that had been requested above once I am free again.

Thanks, Aditya.

Aditya-Chowdhary avatar Oct 13 '24 18:10 Aditya-Chowdhary