dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `RPUSH`: Command returns OK instead of Integer(length of list)

Open Aditya-Chowdhary opened this issue 1 year ago • 2 comments

Steps to reproduce

127.0.0.1:7379> RPUSH mylist 1000 2000

Expected output

The expected output when the above set of commands (maybe when run on Redis)

127.0.0.1:6379> RPUSH mylist 1000 2000
(integer) 2

Observed output

The observed output when the above set of commands when run on DiceDB

127.0.0.1:7379> RPUSH mylist 1000 2000
OK

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. addition of relevant test case to ensure we catch the regression

You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

Aditya-Chowdhary avatar Oct 05 '24 22:10 Aditya-Chowdhary

Wasn't sure if I should include this in #933, so I have created a new issue for RPUSH separately.

Aditya-Chowdhary avatar Oct 05 '24 22:10 Aditya-Chowdhary

Can I pick this up?

codeasashu avatar Oct 07 '24 19:10 codeasashu

Closing merged as part of https://github.com/DiceDB/dice/pull/969

lucifercr07 avatar Oct 08 '24 08:10 lucifercr07