dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `LPUSH`: Command in Dice docs isn't matching while running it via dicedb-cli ( #835 )

Open surya0180 opened this issue 1 year ago • 4 comments

Steps to reproduce

Please refer to this screenshot. Left side is RedisCLI and right side is DiceCLI image

Expected output

The expected output when the above set of commands (maybe when run on Redis)

(integer) 1

Observed output

The observed output when the above set of commands when run on DiceDB

(integer) b'OK'

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. addition of relevant test case to ensure we catch the regression

You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

surya0180 avatar Oct 05 '24 09:10 surya0180

I would love to work on this

bhima2001 avatar Oct 05 '24 09:10 bhima2001

@surya0180 can i take this?

RishabhC-137 avatar Oct 05 '24 09:10 RishabhC-137

Based on the first comment assigning it to @bhima2001

@RishabhC-137 thanks for showing up interest, please check other opened issues.

AshwinKul28 avatar Oct 05 '24 10:10 AshwinKul28

https://github.com/DiceDB/dice/pull/969 --> Please find the PR attached.

bhima2001 avatar Oct 05 '24 17:10 bhima2001

Closing, merged as part of https://github.com/DiceDB/dice/pull/969

lucifercr07 avatar Oct 08 '24 08:10 lucifercr07