dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for Cuckoo Filter

Open ashutoshdhande opened this issue 1 year ago • 6 comments

Implement a Cuckoo Filter in DiceDB, introducing commands CF.ADD, CF.EXISTS, and CF.DEL for adding, checking existence, and deleting elements. A good alternative (for bloom) if a use case requires deletion support on probabilistic structures.

ashutoshdhande avatar Oct 04 '24 12:10 ashutoshdhande

@arpitbbhayani @lucifercr07 I'm currently studying some open-source implementations and will provide progress updates here as I go along.

ashutoshdhande avatar Oct 04 '24 12:10 ashutoshdhande

Hello @ashutoshdhande,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 24 '24 13:10 arpitbbhayani

@arpitbbhayani sorry for the delay man, implemented a version in an isolated environment. You will see a PR for this by saturday evening.

ashutoshdhande avatar Oct 24 '24 13:10 ashutoshdhande

@arpitbbhayani @lucifercr07 Started working on it here is a draft for feedback. This is nowhere the final implementation will polish it as I go ahead.

ashutoshdhande avatar Oct 27 '24 17:10 ashutoshdhande

@ashutoshdhande, I can work on this issue.

kaushal-003 avatar Dec 04 '24 10:12 kaushal-003

@ashutoshdhande, I can work on this issue.

Sure, for now you just need to check if this is consistent with redis. Currently the filter does not include the logic to grow when it is close to its capacity you can take a look at that or feel free to drop a dm on discord we can tag for that.

ashutoshdhande avatar Dec 04 '24 10:12 ashutoshdhande