Inconsistent `LPUSH`: Command returns OK instead of Integer(length of list)
Steps to reproduce
127.0.0.1:7379> lpush mylist "test"
Expected output
The expected output when the above set of commands (maybe when run on Redis)
127.0.0.1:6379> LPUSH mylist "test"
(integer) 1
Observed output
The observed output when the above set of commands when run on DiceDB
127.0.0.1:7379> lpush mylist "test"
OK
Expectations for resolution
This issue will be considered resolved when the following things are done
- changes in the
dicecode to meet the expected behavior - addition of relevant test case to ensure we catch the regression
You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally
Hi, I worked on the doc issue for this command, so would like to contribute to this as well. Thank you.
https://github.com/DiceDB/dice/blob/887d693113e266c8525c75b103346ced5fbdf997/integration_tests/commands/async/deque_test.go#L86
according to the tests, this is the expected behaviour I think.
Though ideally it should return integer
Can I work on this?
@Aditya-Chowdhary assigned, thanks for contributing.
Closing as duplicate PR has been merged.