dice icon indicating copy to clipboard operation
dice copied to clipboard

Http Integration Tests: Create tests to support Hyperloglog

Open lucifercr07 opened this issue 1 year ago • 5 comments

This issue involves creating the below test cases for HTTP as well:

Source: integration_tests/commands/async/

  • hyperloglog_test.go

Steps:

  • Create the corresponding tests for these commands in integration_tests/commands/http.
  • Use set_test.go as a reference, and how to alter the input and output to match JSON structures from RESP.
  • Run the tests and fix issues with command parsing in HTTP.

If you need to do anything custom to support HTTP, let @pratikpandey21 @lucifercr07 know.

lucifercr07 avatar Oct 02 '24 20:10 lucifercr07

@lucifercr07 can you please assign this to me? Just to clarify hyperlog tests need to be added under http right?

abrahamvineel avatar Oct 02 '24 20:10 abrahamvineel

Hey can i take this up. @lucifercr07

rishavvajpayee avatar Oct 02 '24 21:10 rishavvajpayee

@lucifercr07, can I please take this up?

siddharth-reddy-1607 avatar Oct 03 '24 00:10 siddharth-reddy-1607

Hey @lucifercr07 I am already working on this as part of issue #740 . I have already implemented it in PR #873 .

hgupta12 avatar Oct 03 '24 14:10 hgupta12

@lucifercr07 As @hgupta12 already has a PR you can assign this task to him. I will pick another one when it's available. Thanks

abrahamvineel avatar Oct 03 '24 14:10 abrahamvineel

Closing, merged as part of https://github.com/DiceDB/dice/pull/873

lucifercr07 avatar Oct 05 '24 16:10 lucifercr07