dice icon indicating copy to clipboard operation
dice copied to clipboard

Hashmap "incrementFloatValue" overflow check not working

Open dograprabhav opened this issue 1 year ago • 1 comments

 (i > 0 && incr > 0 && i > math.MaxFloat64-incr) 

This returns false even though it should return true in the case i = math.MaxFloat64, incr = 1.0. This should ideally make the condition to be true but it still returns false. There should be a test to check overflow in TestHashMapIncrementFloatValue method.

I can pick up these changes, can you assign this issue to me @lucifercr07 @JyotinderSingh @AshwinKul28 @arpitbbhayani

dograprabhav avatar Oct 02 '24 14:10 dograprabhav

Thanks for reporting this, assigned to you.

JyotinderSingh avatar Oct 02 '24 14:10 JyotinderSingh