dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `MGET`: Command in Dice docs isn't matching while running it via `dicedb-cli`

Open shashi-sah2003 opened this issue 1 year ago • 3 comments

This issue has been raised in accordance to fix issue #823

Steps to reproduce

  1. go to the dicedb-cli after running dicedb server
  2. on cli, SET key "value1"
  3. on cli, LPUSH key4 "value2"
  4. MGET key key4

Expected output (given in documentation of the command)

image

This is the output that given in the dicedb documentation

{expected_output}

Observed output

image

This is the case when keys doesn't exist previously.

NOTE: on the redis-cli and dicedb-cli it's giving the same output for the above command. one thing I have observed is that let's say key4 isn't existence then LPUSH will make a list for key4 and store its value but if keys exists then it will throw the error immediately after executing the LPUSH command. I am attaching for a case also when keys exists.

image

{observed_output}

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. addition of relevant test case to ensure we catch the regression

You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

shashi-sah2003 avatar Oct 02 '24 08:10 shashi-sah2003

Hi @shashi-sah2003. Is someone working on this issue? I would like work on this if no one else is assigned for this issue.

surya0180 avatar Oct 02 '24 12:10 surya0180

Hey @lucifercr07 can you assign this to me .I would like to work on it.

mohdammar128 avatar Oct 02 '24 15:10 mohdammar128

Hi @shashi-sah2003. Is someone working on this issue? I would like work on this if no one else is assigned for this issue.

Assigned.

JyotinderSingh avatar Oct 02 '24 15:10 JyotinderSingh