dice icon indicating copy to clipboard operation
dice copied to clipboard

DiceDB doesn't create AOF file with required permission

Open keshavchand opened this issue 3 years ago • 2 comments

Describe the bug dice-master.aof file created by DiceDB doesn't seem to have the required permission, if the file doesn't already exists. It therefore can't write to the file in its next run.

ls -al dice-master.aof 
---------- 1 chand chand 0 Nov  9 18:47 dice-master.aof

In case file already exists (touch dice-master.aof) it doesn't change permissions.

To Reproduce Steps to reproduce the behavior:

  1. Make sure dice-master.aof file doesn't exists
  2. Run go run main.go
  3. Shut down server
  4. Run ls -al dice-master.aof

Expected behavior File should be created with default permissions 0644 (rw-r-r).

Additional context go version : go version go1.18.1 linux/amd64 running on wsl2

keshavchand avatar Nov 09 '22 13:11 keshavchand

@keshavchand do you want to take this up? I can right away assign.

arpitbbhayani avatar Nov 09 '22 13:11 arpitbbhayani

AOF implementation wrap-up for pending TODOs, coming in a while!

rohanverma94 avatar Nov 09 '22 14:11 rohanverma94

Is this still open? I can take it up if it is.

gsarmaonline avatar Jul 20 '24 21:07 gsarmaonline

Is this still open? I can take it up if it is.

Assigned

JyotinderSingh avatar Jul 28 '24 07:07 JyotinderSingh