dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `COMMAND`: COMMAND INFO DONT BEHAVE SAME WHEN USED ON SELF (ALSO NO RECURSION ON SUB COMMANDS WHEN USED INFO)(eg: COMMAND INFO COMMAND )

Open sa-k-shore opened this issue 1 year ago • 6 comments

Steps to reproduce

COMMAND INFO COMMAND

Expected output

redis behaviour : Screenshot 2024-09-28 at 1 37 44 AM

Observed output

The observed output when the above set of commands when run on DiceDB Screenshot 2024-09-28 at 1 39 36 AM

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. register them based on commands not on command name or change in cmdMeta.Name for command .
  2. make sure to recurse subcommands in case of command info .
  3. addition of relevant test case to ensure we catch the regression.

sa-k-shore avatar Sep 27 '24 20:09 sa-k-shore

i am working on command docs which will face same issue so i would like to get this assigned so i will do it in correct way for docs and correct it for info also , thanks

sa-k-shore avatar Sep 27 '24 20:09 sa-k-shore

@sa-k-shore assigned, thanks for contributing.

lucifercr07 avatar Oct 01 '24 13:10 lucifercr07

i have raised a Merge Request #993 with changes for #641 . please review, thanks.

sa-k-shore avatar Oct 07 '24 12:10 sa-k-shore

Hello @sa-k-shore,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 24 '24 13:10 arpitbbhayani

HI @arpitbbhayani their have been some conflict for my pr and i have fixed them and again their is new conflict yesterday i fixed that we are good to merge

sa-k-shore avatar Oct 24 '24 14:10 sa-k-shore

hi @arpitbbhayani we have merged this issue and websocket test cases i missed and i am picking it as another task

sa-k-shore avatar Oct 24 '24 16:10 sa-k-shore