dice icon indicating copy to clipboard operation
dice copied to clipboard

Marshalling the value in set command

Open lovish2525 opened this issue 1 year ago • 8 comments

Issue link - https://github.com/DiceDB/dice/issues/750

Changes Made:

  1. Handling of values to ensure proper serialization and deserialization of nested map structures in SET command.
  2. Added UTs

lovish2525 avatar Sep 27 '24 17:09 lovish2525

@pratikpandey21 Just want to confirm if the escape characters in API response is fine?

Screenshot 2024-09-29 at 11 03 41 PM

lovish2525 avatar Sep 29 '24 17:09 lovish2525

@pratikpandey21 Testcases are running fine, Please help in next steps to allow approval for the CI workflows

lovish2525 avatar Sep 30 '24 15:09 lovish2525

@pratikpandey21 Just want to confirm if the escape characters in API response is fine?

Screenshot 2024-09-29 at 11 03 41 PM

I don't think escape chars should be there in response. It should be a proper json. @lovish2525 please check once. cc: @pratikpandey21

lucifercr07 avatar Oct 01 '24 05:10 lucifercr07

@pratikpandey21 Just want to confirm if the escape characters in API response is fine? Screenshot 2024-09-29 at 11 03 41 PM

I don't think escape chars should be there in response. It should be a proper json. @lovish2525 please check once. cc: @pratikpandey21

In redis JSON.GET i have noticed escape characters there should not be problem with that as long as client is able to parse it without having errors

vinitparekh17 avatar Oct 02 '24 04:10 vinitparekh17

@vinitparekh17 @pratikpandey21 Fixed http UTs

lovish2525 avatar Oct 02 '24 07:10 lovish2525

@vinitparekh17 So are we good to go with escape chars?

lovish2525 avatar Oct 03 '24 05:10 lovish2525

@lovish2525 looks like redis does have escape chars in response. I believe we can keep the same. Meanwhile, please fix the build errors. cc: @pratikpandey21

lucifercr07 avatar Oct 03 '24 09:10 lucifercr07

@lucifercr07 Kindly approve the workflow

lovish2525 avatar Oct 03 '24 10:10 lovish2525

@lovish2525 lgtm @lucifercr07 hold on this marge for a while, i am about to create pr for http response in proper json format

vinitparekh17 avatar Oct 05 '24 05:10 vinitparekh17