dice icon indicating copy to clipboard operation
dice copied to clipboard

Added Test Cases for EXISTS, ECHO and EXPIRE with HTTP Issue #737

Open harsh082ip opened this issue 1 year ago • 7 comments

As mentioned on the issue, I've completed 2/5 of the given test cases (i.e. EXISTS and ECHO), and I'll also create PR for the remaining test cases soon

EXISTS test cases - screenshot image

ECHO test cases - screenshot image

harsh082ip avatar Sep 27 '24 09:09 harsh082ip

Hii @lucifercr07 @pratikpandey21 @JyotinderSingh

Can you please review this PR, I'll create PR for the remaining test cases in the issue soon Please let me know if any changes are required

Regards,

harsh082ip avatar Sep 27 '24 10:09 harsh082ip

Thank you for your feedback, I'll soon create PR of the remaining test cases as well

harsh082ip avatar Sep 28 '24 01:09 harsh082ip

Deploy Preview for dicedb-docs2 failed.

Name Link
Latest commit da07b7b3b58d43eb056f2e4e7b6ffd98f6f957e9
Latest deploy log https://app.netlify.com/sites/dicedb-docs2/deploys/66f87a97a4ed0c00080a1af7

netlify[bot] avatar Sep 28 '24 21:09 netlify[bot]

Update!!! I've added test cases for EXPIRE with HTTP

image

Hii, @apoorvyadav1111 @pratikpandey21 @arpitbbhayani @lucifercr07

Can you please review these changes

harsh082ip avatar Sep 28 '24 22:09 harsh082ip

Hi everyone!

@apoorvyadav1111 @pratikpandey21 @arpitbbhayani @lucifercr07

I'm encountering an issue where the build checks are failing. In the logs, I’m seeing the following error:

npm error enoent Could not read package.json: Error: ENOENT: no such file or directory, open '/opt/build/repo/docs/package.json'

Could this be related to the integration tests or the React app setup? Or am I possibly missing something else that could be causing this?

harsh082ip avatar Sep 28 '24 22:09 harsh082ip

@harsh082ip ignore these workflows for now, if your lint and dice-test-suite builds are passing you should be fine.

lucifercr07 avatar Sep 29 '24 04:09 lucifercr07

Ok @lucifercr07 , Thank you for clarifying

harsh082ip avatar Sep 29 '24 04:09 harsh082ip

Thank you for reviewing and merging the PR, but these two test cases are pending (i.e. expireat_test.go & expiretime_test.go)

I'll create a PR related to this by tomorrow

Regards,

harsh082ip avatar Sep 29 '24 17:09 harsh082ip

#865

Hii @apoorvyadav1111 @pratikpandey21 , I've created the PR for the remaining test cases (i.e. for EXPIREAT & EXPIRETIME), Can you please review this and please let me know in case of any changes

Regards,

harsh082ip avatar Sep 29 '24 20:09 harsh082ip