dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Added JSON.RESP Command

Open psrvere opened this issue 1 year ago • 3 comments

Old PR - #631 (closed)

This PR fixes #500

The PR

  • Adds support for JSON.RESP command
  • Adds unit and integrations test for the same
  • Modifies resp.go to support boolean and integer encoding, and adds unit tests for the same
  • Adds a utility helper IsFloatToIntPossible

psrvere avatar Sep 27 '24 08:09 psrvere

@JyotinderSingh - Please review this PR.

I closed the old PR due to some issues I was facing merging with master. You had left 4 comments there. 3 of them are addressed in 3 commits above. 1 was a question on type switch for which I have left a comment there.

psrvere avatar Sep 27 '24 09:09 psrvere

Please resolve conflicts.

JyotinderSingh avatar Sep 29 '24 14:09 JyotinderSingh

@JyotinderSingh - addressed all comments. Please review.

psrvere avatar Sep 30 '24 10:09 psrvere