dice icon indicating copy to clipboard operation
dice copied to clipboard

Http Integration Tests: Create tests to support HTTP(4)

Open pratikpandey21 opened this issue 1 year ago • 4 comments

This issue involves creating the below test cases for HTTP as well:

Source: integration_tests/commands/async/

  • echo_test.go
  • exists_test.go
  • expire_test.go
  • expireat_test.go
  • expiretime_test.go

Steps:

  1. Create the corresponding tests for these commands in integration_tests/commands/http.
  2. Use set_test.go as a reference, and how to alter the input and output to match JSON structures from RESP.
  3. Run the tests and fix issues with command parsing in HTTP.

If you need to do anything custom to support HTTP, let @pratikpandey21 @lucifercr07 know.

pratikpandey21 avatar Sep 26 '24 17:09 pratikpandey21

Can i take this up?

harsh082ip avatar Sep 26 '24 19:09 harsh082ip

@harsh082ip assigned, thanks for contributing.

lucifercr07 avatar Sep 26 '24 19:09 lucifercr07

#752

Hii @pratikpandey21 @lucifercr07 , can u please review this PR, I have completed 2/5 test cases for HTTP (i.e. for EXISTS and ECHO), I've also attached screenshots of test cases output as well And I will create PR for remaining test cases soon Please let me know if any changes are required

Regards,

harsh082ip avatar Sep 27 '24 09:09 harsh082ip

#752

Hii, Can anyone please review my PR, I'm facing an error there regarding some checks

Regards,

harsh082ip avatar Sep 28 '24 22:09 harsh082ip

Closing, merged as part of #752

lucifercr07 avatar Sep 29 '24 17:09 lucifercr07

Hii @lucifercr07 ,

Thank you for reviewing and merging the PR, but these two test cases are pending (i.e. expireat_test.go & expiretime_test.go)

I will create a PR for these by tomorrow

Regards

harsh082ip avatar Sep 29 '24 17:09 harsh082ip