dice icon indicating copy to clipboard operation
dice copied to clipboard

Http Integration Tests: Create tests to support HTTP(3)

Open pratikpandey21 opened this issue 1 year ago • 10 comments

This issue involves creating the below test cases for HTTP as well:

Source: integration_tests/commands/async/

  • dbsize_test.go
  • decr_test.go
  • del_test.go
  • deque_test.go
  • discard_test.go

Steps:

  1. Create the corresponding tests for these commands in integration_tests/commands/http.
  2. Use set_test.go as a reference, and how to alter the input and output to match JSON structures from RESP.
  3. Run the tests and fix issues with command parsing in HTTP.

If you need to do anything custom to support HTTP, let @pratikpandey21 @lucifercr07 know.

pratikpandey21 avatar Sep 26 '24 17:09 pratikpandey21

I'd like to work on this

shardul08 avatar Sep 26 '24 17:09 shardul08

I don't have the permissions to assign you, but please go ahead and start @shardul08

pratikpandey21 avatar Sep 26 '24 17:09 pratikpandey21

Hello @shardul08,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 03 '24 14:10 arpitbbhayani

Hello @shardul08,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 09 '24 02:10 arpitbbhayani

Hey @arpitbbhayani can I work on this?

rigved-telang avatar Oct 19 '24 07:10 rigved-telang

@rigved-telang assigned, thanks for contributing.

lucifercr07 avatar Oct 19 '24 08:10 lucifercr07

Thanks @lucifercr07.

rigved-telang avatar Oct 19 '24 16:10 rigved-telang

Hello @rigved-telang,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 24 '24 13:10 arpitbbhayani

@arpitbbhayani I am working on it, the test for db_size has been written. This is the first time I am working on DiceDB and with golang which is why the progress is a little slower. Apologies for the delay

rigved-telang avatar Oct 24 '24 13:10 rigved-telang

Also, I was not putting the issue number in my commits. Will be mindful of this going forward.

rigved-telang avatar Oct 24 '24 13:10 rigved-telang