dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `{storm}`: <Incorrect filepath in DOC.md for storm>

Open adityakiran1423 opened this issue 1 year ago • 6 comments

Steps to reproduce

Running the command go run storm/set/main.go will result in an error,. No file called main.go in storm/set folder (line 19 DOC.md)

current path in DOC.md to run storm : go run storm/set/main.go revised path required to run storm : go run storm/set/set.go

Expected output

The expected path to run storm should be :

go run storm/set/set.go

Observed output

Running storm/set/main.go results :

go: downloading go1.23.0 (linux/amd64)
stat storm/set/main.go: no such file or directory

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. path is changed from storm/set/main.go to storm/set/set.go

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

adityakiran1423 avatar Sep 25 '24 08:09 adityakiran1423

Is it possible to assign the issue to myself?

EDIT : created branch issue-720, need authorization to push code. Getting an error if done otherwise.

adityakiran1423 avatar Sep 25 '24 08:09 adityakiran1423

created branch issue-720, need authorization to push code. Getting an error if done otherwise.

@adityakiran1423 you need to fork the repo and make changes in your copy and raise the PR to this repo. Please follow CONTRIBUTING.md for detailed instructions.

shardul08 avatar Sep 25 '24 10:09 shardul08

@shardul08 , apologies for the context, I meant to say that I am not able to push to my branch (issue-720). I looked up CONTRIBUTING.md, I was going to raise a PR after I pushed to my branch, however I ran into this :

issue720

I was wondering if you could help me with this Thanks -Aditya

adityakiran1423 avatar Sep 25 '24 10:09 adityakiran1423

Seems like you are trying to push the branch to DiceDB repo. You will need to create a fork of DiceDB repo, create a new branch in the forked repo, make changes and push it. Once the new branch is pushed to the forked repo you will be able to raise the PR.

shardul08 avatar Sep 25 '24 10:09 shardul08

Yep, totally forgot to fork the repo, apologies for the oversight Followed the instructions are raised a PR Link to the PR Thanks for the help -Aditya

adityakiran1423 avatar Sep 25 '24 11:09 adityakiran1423

@shardul08, Hello, was wondering if there is any update on PR : #721

adityakiran1423 avatar Sep 26 '24 12:09 adityakiran1423