dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Added Websocket support

Open psrvere opened this issue 1 year ago • 4 comments

Closes #555 and #557

This PR

  • adds support for Websocket to interact with diceDB. It supports all the commands except Qwatch, Qunwatch and Subscribe.
  • adds one more server for Websocket in websocketServer.go
  • adds a cli like string based parsing logic ParseWebsocketMessage to support commands from websocket
  • adds unit tests for parsing logic
  • uses new evaluation for migrated commands for Websocket
  • adds integrations tests for SET command

psrvere avatar Sep 22 '24 13:09 psrvere

@pratikpandey21 - Please review cc - @soumya-codes @AshwinKul28

psrvere avatar Sep 23 '24 10:09 psrvere

@pratikpandey21 - Resolved the comment. Please review.

psrvere avatar Sep 23 '24 23:09 psrvere

@lucifercr07 - please review.

psrvere avatar Sep 24 '24 10:09 psrvere

@psrvere , why are we modelling WS commands as HTTP ones? Why can't we follow the same way we interact using RESP?

Screenshot 2024-09-25 at 22 43 24

pratikpandey21 avatar Sep 25 '24 20:09 pratikpandey21