dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `BITPOS`: BITPOS bit=1 works with intervals

Open lucifercr07 opened this issue 1 year ago • 7 comments

Steps to reproduce

Run the commands mentioned in the test on Line 380 in the file https://github.com/AshwinKul28/dice-tests/blob/main/tcltests/unit/bitpos.tcl#L380.

Expected output

The expected output when the above set of commands when run on Redis

Expected [r bitpos str 1 8 -1 bit]

Observed output

The observed output when the above set of commands when run on DiceDB

8 (context: type eval line 10 cmd {assert {[r bitpos str 1 8 -1 bit]

The steps to run the test cases are mentioned in the README of the dice-tests repository.

Expectations for resolution

This issue will be considered resolved when the following things are done:

  1. Changes in the dice repository code to meet the expected behavior.
  2. Successful run of the tcl test behavior.

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

lucifercr07 avatar Sep 20 '24 18:09 lucifercr07

Hi @lucifercr07 , can you assign this task to me?

Nijin-P-S avatar Sep 21 '24 03:09 Nijin-P-S

Hi @lucifercr07, can I take this up?

karandixit10 avatar Sep 21 '24 08:09 karandixit10

Hi @lucifercr07 Can I take this up ? Would love to work on it. Thanks

jainbhavya53 avatar Sep 21 '24 09:09 jainbhavya53

@Nijin-P-S Go for it. Thanks

@karandixit10 @jainbhavya53 Please check for other opened issues. Thanks for your interest. Means a lot!

AshwinKul28 avatar Sep 21 '24 10:09 AshwinKul28

@karandixit10 assigned, thanks for picking this up.

lucifercr07 avatar Sep 21 '24 10:09 lucifercr07

Hi @lucifercr07 This issue has the same scenario as #669. Shall I work on this or is it being worked on by someone else?

karandixit10 avatar Sep 22 '24 10:09 karandixit10

PR: https://github.com/DiceDB/dice/pull/716

jainbhavya53 avatar Sep 25 '24 09:09 jainbhavya53

@lucifercr07 Can you please assign this issue to me and close it ? Its fixed by https://github.com/DiceDB/dice/pull/716

jainbhavya53 avatar Sep 28 '24 06:09 jainbhavya53

Merged as part of https://github.com/DiceDB/dice/pull/716

lucifercr07 avatar Sep 28 '24 07:09 lucifercr07