dice icon indicating copy to clipboard operation
dice copied to clipboard

Inconsistent `BITCOUNT`: BITCOUNT against test vector #5

Open lucifercr07 opened this issue 1 year ago • 3 comments

Steps to reproduce

Run the commands mentioned in the test on Line 68 in the file https://github.com/AshwinKul28/dice-tests/blob/main/tcltests/unit/bitpos.tcl#L68.

Expected output

The expected output when the above set of commands when run on Redis

Expected [r bitcount str 0 -1 bit]

Observed output

The observed output when the above set of commands when run on DiceDB

10 (context: type eval line 5 cmd {assert {[r bitcount str 0 -1 bit]

The steps to run the test cases are mentioned in the README of the dice-tests repository.

Expectations for resolution

This issue will be considered resolved when the following things are done:

  1. Changes in the dice repository code to meet the expected behavior.
  2. Successful run of the tcl test behavior.

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

lucifercr07 avatar Sep 20 '24 18:09 lucifercr07

Hi @lucifercr07 , can you assign this task to me?

Nijin-P-S avatar Sep 21 '24 04:09 Nijin-P-S

@Nijin-P-S assigned, thanks for contributing.

lucifercr07 avatar Sep 21 '24 05:09 lucifercr07

Hi @lucifercr07 ,

I wanted to reach out regarding the issues I was assigned. Despite my efforts, I’m finding it challenging to make progress on them. Additionally, I have a busy period at my full-time job coming up and won’t be able to dedicate the time needed for the next couple of weeks.

I think it would be best for me to unassign these issues so someone else can take them on. Thank you for understanding, and I hope to contribute again in the future!

Nijin-P-S avatar Sep 22 '24 17:09 Nijin-P-S

@lucifercr07 - can you please assign this issue to me? i would like to work on a PR

EDIT: seems to be solved in https://github.com/DiceDB/dice/issues/660

sahoss avatar Oct 06 '24 12:10 sahoss

Closing, fixed as part of https://github.com/DiceDB/dice/pull/699

lucifercr07 avatar Oct 06 '24 12:10 lucifercr07