dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `LINSERT`

Open arpitbbhayani opened this issue 1 year ago • 11 comments

Add support for the LINSERT command in DiceDB similar to the LINSERT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Sep 20 '24 17:09 arpitbbhayani

Hi @arpitbbhayani, please assign this to me, I can work on it.

TIA

ParvBudh28 avatar Sep 20 '24 17:09 ParvBudh28

@ParvBudh28 Thanks for taking this up. assigned.

arpitbbhayani avatar Sep 20 '24 17:09 arpitbbhayani

Hi @ParvBudh28 ! are you still working on it? @arpitbbhayani can i pick this up?

RishabhC-137 avatar Sep 25 '24 13:09 RishabhC-137

Hey, yes I am working on this. Will raise the PR in a few days.

ParvBudh28 avatar Sep 25 '24 14:09 ParvBudh28

Hey @ParvBudh28 are you still working on it ? If not, can I take this up?

anchalsinghrajput avatar Oct 01 '24 15:10 anchalsinghrajput

Hey, yes. I've implemented it, working on writing tests now.

ParvBudh28 avatar Oct 01 '24 16:10 ParvBudh28

Have raised a draft PR for early review with unit tests. Will add integration tests and benchmarking.

ParvBudh28 avatar Oct 03 '24 18:10 ParvBudh28

Hello @ParvBudh28,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 09 '24 02:10 arpitbbhayani

Hey Arpit, raised the PR with tests. Waiting for review.

ParvBudh28 avatar Oct 09 '24 05:10 ParvBudh28

Hello @ParvBudh28,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 24 '24 13:10 arpitbbhayani

Hello @ParvBudh28,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

The PR is under final stages of review.

ParvBudh28 avatar Oct 25 '24 06:10 ParvBudh28