dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `HSCAN`

Open arpitbbhayani opened this issue 1 year ago • 11 comments

Add support for the HSCAN command in DiceDB similar to the HSCAN command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Sep 20 '24 17:09 arpitbbhayani

I would like to work on this

Saitharun279 avatar Sep 20 '24 17:09 Saitharun279

@Saitharun279 Thanks for taking this up. assigned.

arpitbbhayani avatar Sep 20 '24 18:09 arpitbbhayani

Hey @Saitharun279 , are you still working on this? Will be happy to pick this up!

iamskp11 avatar Sep 25 '24 03:09 iamskp11

Hey @Saitharun279, are you still working on this issue? If not, Can I pick this up?

anchalsinghrajput avatar Sep 25 '24 18:09 anchalsinghrajput

Hey @iamskp11 , @anchalsinghrajput im actively spending time on this issue, i would need some more to finish it as im new to golang

Saitharun279 avatar Sep 25 '24 18:09 Saitharun279

I see it open from long time. I can take it up if it's not making any progress.

manishrw avatar Oct 02 '24 06:10 manishrw

I've created the PR for this command - #907

manishrw avatar Oct 02 '24 08:10 manishrw

Unassigned my self @manishrw please ask the moderators to assign this to you

Saitharun279 avatar Oct 02 '24 11:10 Saitharun279

@arpitbbhayani can you assign this to me ??

mohdammar128 avatar Oct 02 '24 15:10 mohdammar128

Hello @manishrw,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 09 '24 02:10 arpitbbhayani

Hello @manishrw,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 24 '24 13:10 arpitbbhayani

@lucifercr07 Can we mark this as done? I think it keeps getting flagged for @arpitbbhayani

manishrw avatar Oct 27 '24 04:10 manishrw

Closing, merged as part of https://github.com/DiceDB/dice/pull/907

lucifercr07 avatar Oct 27 '24 05:10 lucifercr07