dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `HMSET`

Open arpitbbhayani opened this issue 1 year ago • 7 comments

Add support for the HMSET command in DiceDB similar to the HMSET command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Sep 20 '24 17:09 arpitbbhayani

@arpitbbhayani please assign this to me

raghavbabbar avatar Sep 20 '24 17:09 raghavbabbar

@raghavbabbar Thanks for taking this up. assigned.

arpitbbhayani avatar Sep 20 '24 17:09 arpitbbhayani

@arpitbbhayani Can I work on this issue if no one is working on it?

karandixit10 avatar Sep 25 '24 10:09 karandixit10

Hey! @karandixit10 i am working on it

raghavbabbar097 avatar Sep 25 '24 13:09 raghavbabbar097

Hey @raghavbabbar, are you still working on this, if not can I take this up ?

anchalsinghrajput avatar Oct 01 '24 15:10 anchalsinghrajput

Hey I was unwell from sometime ! There will be PR to night

raghavbabbar avatar Oct 02 '24 10:10 raghavbabbar

https://github.com/DiceDB/dice/pull/960

raghavbabbar avatar Oct 05 '24 09:10 raghavbabbar