dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `HINCRBYFLOAT`

Open arpitbbhayani opened this issue 1 year ago • 4 comments

Add support for the HINCRBYFLOAT command in DiceDB similar to the HINCRBYFLOAT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Sep 20 '24 17:09 arpitbbhayani

Can I take this issue @arpitbbhayani @JyotinderSingh

ayushsatyam146 avatar Sep 20 '24 18:09 ayushsatyam146

Can I take this issue @arpitbbhayani @JyotinderSingh

Assigned

JyotinderSingh avatar Sep 20 '24 18:09 JyotinderSingh

@arpitbbhayani Can I pick this issue?

swarajrb7 avatar Sep 20 '24 18:09 swarajrb7

I am posting this comment to update the status of this issue. I have implemented the basic functionality and am currently writing tests for this command. I will raise the PR in a couple of days. Thanks!

ayushsatyam146 avatar Sep 25 '24 13:09 ayushsatyam146