dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `COMMAND GETKEYSANDFLAGS`

Open arpitbbhayani opened this issue 1 year ago • 14 comments

Add support for the COMMAND GETKEYSANDFLAGS command in DiceDB similar to the COMMAND GETKEYSANDFLAGS command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Sep 20 '24 17:09 arpitbbhayani

Hi , Can I give it a try ?

YuvrajGosain avatar Sep 20 '24 18:09 YuvrajGosain

Hi @arpitbbhayani , I am excited to work on this issue. Can you please assigned it to me?

meetghodasara avatar Sep 21 '24 06:09 meetghodasara

Hi @arpitbbhayani, could you please assign this to me?

Go-coder-go avatar Sep 21 '24 09:09 Go-coder-go

Hi @arpitbbhayani I am also interested to work on this issue.

kapishmalik avatar Sep 21 '24 19:09 kapishmalik

Hi , Can I give it a try ?

Assigned

JyotinderSingh avatar Sep 23 '24 02:09 JyotinderSingh

hi @YuvrajGosain, are you still working on this issue? If not, Can I pick this up?

anchalsinghrajput avatar Sep 25 '24 18:09 anchalsinghrajput

Hi @anchalsinghrajput , yes i am working on this, will be raising the PR in next 2-3 days.

YuvrajGosain avatar Sep 26 '24 02:09 YuvrajGosain

Hello @YuvrajGosain,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 03 '24 14:10 arpitbbhayani

Hi @arpitbbhayani , test cases are pending, will raise the PR by tomorrow.

YuvrajGosain avatar Oct 03 '24 14:10 YuvrajGosain

#1035 , Here is the PR this . @JyotinderSingh Can you please help review.

YuvrajGosain avatar Oct 08 '24 20:10 YuvrajGosain

Hi @JyotinderSingh, @AshwinKul28 , @apoorvyadav1111 , can someone pls help review this PR.

YuvrajGosain avatar Oct 17 '24 15:10 YuvrajGosain

Hello @YuvrajGosain,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 24 '24 13:10 arpitbbhayani

@YuvrajGosain are you still working on this issue?

tarun-29 avatar Dec 01 '24 17:12 tarun-29

@arpitbbhayani @JyotinderSingh Can I take this one??

vaibhavyadav-dev avatar Jun 17 '25 12:06 vaibhavyadav-dev